There is a saying that if you don’t be embarrassed by code that you wrote six month ago, you haven’t learned anything. Recently, I stumbled upon a C/C++ project that dates back to the very early days of my programming career – this was many * six months ago – and I can tell you, I was very embarrassed.
I had just “learned” C++ and object-orientation at that time and, of course, wanted to program that way. The result was terrible. The only small piece of object-orientation was the use of the keyword class. There were public fields all over the place, no interfaces or abstractions of any kind, switches over type-ids, and so on.
Another highlight was the vast amount of literals scattered all over the code. For example, as it was a curses-based application, I had to read and display user input using curses methods like
int mvwgetch(WINDOW *win, int y, int x);
int mvwaddch(WINDOW *win, int y, int x, const chtype ch);
And what did I do? I hard-coded y and x positions on every call of those methods. So it would often be the case that I changed, say, the y position in one part and … well, you guessed it already.
Naming of variables was also big. Boolean values would often be called “flag”, a name length of more than 4 was considered way too long.
But there was also progress. In later parts of the software I started to use “advanced” things like auto_ptrs, std::list, and std::map. Hooray!
The only positive thing about this project was that since I made every possible mistake one can imagine, I learned quite lot about programming. And I remember that at the end of the project, I was already very embarrassed about the whole thing…
So if you like reading horror stories, try digging up your old code 😉 And share if you like.
One thought on “Old Code”